Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avatar status icon text misalignment #6580

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: avatar status icon text misalignment #6580

merged 1 commit into from
Dec 23, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Dec 18, 2024 •
edited
Loading

before
Screenshot from 2024-12-18 17-51-04

after
Screenshot from 2024-12-18 18-14-13

@GretaD GretaD added the 3. to review Waiting for reviews label Dec 18, 2024
@GretaD GretaD self-assigned this Dec 18, 2024
ChristophWurst
ChristophWurst previously requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't restore how it looked.

The status icon was part of the subline. This is also the reason why the subline is indented.

@ChristophWurst
Copy link
Member

Check out https://docs.nextcloud.com/server/29/user_manual/en/groupware/calendar.html#invite-attendees-to-an-event for what the view is intended to look like.

@GretaD GretaD force-pushed the fix/avatar-status-icon branch from c10cf28 to 88448a7 Compare December 18, 2024 17:14
@GretaD
Copy link
Contributor Author

GretaD commented Dec 18, 2024 •
edited
Loading

This doesn't restore how it looked.

The status icon was part of the subline. This is also the reason why the subline is indented.

ok, changed it to how it used to look. It was confusing what was supposed to be done, because the initial screenshot you sent its not reproducible.

@ChristophWurst
Copy link
Member

The main line (attendee name) and the icon in the subline do not align

@GretaD GretaD force-pushed the fix/avatar-status-icon branch from 88448a7 to a319898 Compare December 18, 2024 17:25
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.40%. Comparing base (91d787c) to head (f837082).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #6580   +/-   ##
=========================================
  Coverage     23.40%   23.40%           
  Complexity      472      472           
=========================================
  Files           249      249           
  Lines         11901    11901           
  Branches       2283     2283           
=========================================
  Hits           2786     2786           
  Misses         8788     8788           
  Partials        327      327
Flag Coverage Δ
javascript 14.84% <ø> (ø)
php 59.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD GretaD force-pushed the fix/avatar-status-icon branch from a319898 to f837082 Compare December 23, 2024 14:01
@GretaD GretaD enabled auto-merge December 23, 2024 14:02
@GretaD GretaD merged commit 03f3330 into main Dec 23, 2024
38 checks passed
@GretaD GretaD deleted the fix/avatar-status-icon branch December 23, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@st3iny st3iny Awaiting requested review from st3iny st3iny is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@GretaD GretaD

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GretaD @ChristophWurst @SebastianKrupinski